Remove serverHeader #591
Merged
Remove serverHeader #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornjad
changed the title
|
Hey @zbynek you've been super active lately, what do you think of this PR? |
zbynek
approved these changes
Aug 6, 2021
|
Yup, so I'm not so worried about the use case that requires this header |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
serverheader was being served all the time by http-server to identify itself. While not usually a big deal, this is unnecessary and potentially reveals security vulnerabilities. Taking a page from engineering, I ask, why do we even need it? This PR removes the server header.Fixes #237