Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative paths in directory listing #661 #732

merged 1 commit into from Oct 1, 2021


Copy link

Hi there. Thanks for your all continuous work on this! I've fixed #661, please review.

Please ensure that your pull request fulfills these requirements:

  • The pull request is being made against the master branch
  • Tests for the changes have been added (for bug fixes / features)

What is the purpose of this pull request? (bug fix, enhancement, new feature,...)


What changes did you make?

Paths in directory listing to be relative



Is there anything you'd like reviewers to focus on?

I'm not sure that the tests are fixed properly, so please focus on those.

Please provide testing instructions, if applicable:

I tested in following way:

  1. Run npm run test

There was no error and it says "371 passing".

  1. Run ./bin/http-server ./, check the paths on http://localhost:8080

Result image is above.

@thornjad thornjad added the patch version Small, non-breaking, bug fix or trivial change label Oct 1, 2021
Copy link

thornjad commented Oct 1, 2021

This looks good! The failing test is an unrelated non-deterministic issue we're having problems with, I'm going to re-run it until it passes before merging. Thank you!

@thornjad thornjad merged commit 693ad87 into http-party:master Oct 1, 2021
@boarwell boarwell deleted the relative-paths branch October 1, 2021 12:32
@thornjad thornjad added this to the v14.0 milestone Oct 11, 2021
@thornjad thornjad added the fix label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
fix patch version Small, non-breaking, bug fix or trivial change
None yet

Successfully merging this pull request may close these issues.

Use relative paths in directory listing?
2 participants