Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node.js 10 support #739

merged 1 commit into from Oct 11, 2021


Copy link

@boarwell boarwell commented Oct 5, 2021

Please ensure that your pull request fulfills these requirements:

  • The pull request is being made against the master branch
  • Tests for the changes have been added (for bug fixes / features)

What is the purpose of this pull request? (bug fix, enhancement, new feature,...)

Drop Node.js 10 support, which has been EOL since 2021-04-301.

What changes did you make?

Updated engines in package.json and remove node-version: 10.x from .github/workflows/node.js.yml.



@boarwell boarwell mentioned this pull request Oct 5, 2021
2 tasks
@thornjad thornjad added the major version Major, potentially breaking, change label Oct 5, 2021
Copy link

thornjad commented Oct 5, 2021

Discussion in #736

Copy link
Contributor Author

boarwell commented Oct 7, 2021

Rebased onto master

Copy link

I was going to say we should wait for v17 to release next week, but I'd rather include this in a major release I plan to make sooner. Adding explicit Node 17 support can be a minor release later

@thornjad thornjad merged commit 8ca74b5 into http-party:master Oct 11, 2021
@thornjad thornjad added this to the v14.0 milestone Oct 11, 2021
@boarwell boarwell deleted the drop-node-10 branch October 14, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
enhancement major version Major, potentially breaking, change
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants