Adding an option to launch a HTTPS server #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be helping for issue #36. |
|
UP! |
|
Great. |
| @@ -21,6 +21,11 @@ if (argv.h || argv.help) { | |||
| " -o Open browser window after staring the server", | |||
| " -c Set cache time (in seconds). e.g. -c10 for 10 seconds.", | |||
| " To disable caching, use -c-1.", | |||
| "", | |||
| " -S --ssl Enable https.", | |||
There was a problem hiding this comment.
Seem like these being lowercase would fit the existing code style a bit better.
There was a problem hiding this comment.
Only the -S or every one (would need to find another letter then)?
|
This would be such a welcome change. |
indexzero
added a commit
that referenced
this pull request
Aug 28, 2014
Adding an option to launch a HTTPS server
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding several options concerning HTTPS:
The arguments are uppercase not to collide with the current existing one.
The idea behind this pull request is to enable developers to fastly launch a https server for dev purposes (typically when working on Speech Recognition APIs or on code injection within HTTPS pages).
How to create dummy cert and key files for dev
openssl genrsa -out key.pem 4096 openssl req -new -key key.pem -out csr.pem -subj "/C=US/ST=California/L=San Francisco/O=Local-Company/OU=dev/CN=localhost/emailAddress=test@test.com" openssl x509 -req -days 9999 -in csr.pem -signkey key.pem -out cert.pem rm csr.pemThen go to chrome settings to register your key (advanced settings --> HTTPS/SSL --> Manage Certificates)
Click
Importand add your cert.pem file to register your development certificate and not be bothered anymore by chrome warnings.Or use the
--ignore-certificate-errorsoption in Chromium if you are in a hurry.