Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from colors to chalk #785

merged 1 commit into from Jan 10, 2022

Switch from colors to chalk #785

merged 1 commit into from Jan 10, 2022


Copy link

@zbynek zbynek commented Jan 10, 2022

Alternative to #783 -- instead of locking the last version of colors, use chalk: same size, same syntax, more widespread (hopefully more stable). Currently use version 4 so that it can be required rather than imported. Switch to ESM can be done in later PR.

Contributor checklist
  • [n/a] Provide tests for the changes (unless documentation-only)
  • [n/a] Documented any new features, CLI switches, etc. (if applicable)
    • [n/a] Server --help output
    • [n/a]
    • [n/a] doc/http-server.1 (use the same format as other entries)
  • The pull request is being made against the master branch
Maintainer checklist
  • Assign a version triage tag
  • Approve tests if applicable

Copy link

Soni96pl commented Jan 10, 2022

Thanks for this change @zbynek
For anyone in need of http-server meanwhile can run code from this branch with:
npx git+ssh://

@thornjad thornjad added the minor version non-breaking, non-trivial change label Jan 10, 2022
Copy link

@thornjad thornjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests on Node 17 have unrelated problems, and this PR is more important than them, so I'm going to ignore them for now.

@thornjad thornjad merged commit 56bdf6e into http-party:master Jan 10, 2022
@zbynek zbynek deleted the use-chalk branch January 10, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
minor version non-breaking, non-trivial change
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants