Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests on stable Node 0.10.28 #657

Closed
Rush opened this issue Jun 9, 2014 · 3 comments
Closed

Failing tests on stable Node 0.10.28 #657

Rush opened this issue Jun 9, 2014 · 3 comments

Comments

@Rush
Copy link
Contributor

Rush commented Jun 9, 2014

I wanted to add a new feature to node-http-proxy but how am I supposed to contribute it if the tests fail even on stable Node 0.10.28?

Latest master:

38 passing (2s)
  3 pending
  1 failing

  1) lib/http-proxy.js #createProxyServer using the ws-incoming passes should proxy a socket.io stream:
     Error: timeout of 2000ms exceeded
@jcrugzz
Copy link
Contributor

jcrugzz commented Jun 10, 2014

@RushPL the devDeps are * depped so that was the root cause.

@Rush
Copy link
Contributor Author

Rush commented Jun 10, 2014

Should I change them to "--save-dev" in my pull request?

@jcrugzz
Copy link
Contributor

jcrugzz commented Jun 10, 2014

@RushPL we might as well ensure our tests are up to date so lets keep living dangerously ;).

Rush added a commit to Rush/node-http-proxy that referenced this issue Jun 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants