Support sending events without an event: field for the event name
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event field is optional in the specification, and adds overhead, which some applications do not want. Allow omitting it. To simplify use, accept the name as `impl Into<Option<&str>>`, which allows existing code that passes `"name"` to continue working. Since this can potentially cause an inference failure in code that previously compiled, bump the major version, but *most* code should continue working with just a recompile.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event field is optional in the specification, and adds overhead,
which some applications do not want. Allow omitting it.
To simplify use, accept the name as
impl Into<Option<&str>>, whichallows existing code that passes
"name"to continue working. Sincethis can potentially cause an inference failure in code that previously
compiled, bump the major version, but most code should continue
working with just a recompile.