Stabilize config #95
Merged
Stabilize config #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only supports `timeout`, unfortunately, and requires async-std...
Fishrock123
force-pushed
the
stabilize-config
branch
from
4da2b33
to
b414c9f
Compare
I've been using this in projects for a couple months now, and would like to land support in Surf directly, for which this should be stabilized. Refs: http-rs/surf#310 Refs: http-rs#86 Closes: http-rs#93
Follow-up for stabilising Config.
Fishrock123
force-pushed
the
stabilize-config
branch
from
b414c9f
to
14dd1bb
Compare
pepoviola
reviewed
Aug 11, 2021
| let mut res = req.send().await?; | ||
| let conn = req.send(); | ||
| let mut res = if let Some(timeout) = config.timeout { | ||
| async_std::future::timeout(timeout, conn).await?? |
There was a problem hiding this comment.
Hi @Fishrock123, just out of curiosity is this line ok? I think should be one ?.
Thanks!!
There was a problem hiding this comment.
Yes, this does compile, it is roughly equivalent to the following:
let mut res = if let Some(timeout) = config.timeout {
async_std::future::timeout(timeout, conn).await?
} else {
conn.await
}?;Basically... timeout has it's own error and then the connection await has it's error... this is like a cheap-seats Result::flatten() (which is still unstable).
There was a problem hiding this comment.
Awesome 🙌, thanks for the explanation!!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this in projects for a couple months now, and would like to land support in Surf directly, for which this should be stabilized.
This also adds the following things for stabilization:
Configtimeout, unfortunately, and requires async-std...Config::max_connections_per_hostH1Client::with_max_connections()has been deprecated.