Clean up dependencies #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove dependencies that had been moved into http-client. Use the http-client features for curl/wasm/h1. Remove mentions of hyper entirely as it is not currently implemented.
yoshuawuyts
reviewed
Apr 22, 2020
| middleware-logger = [] | ||
| encoding = ["encoding_rs"] | ||
| # requires web-sys for TextDecoder on wasm | ||
| encoding = ["encoding_rs", "web-sys"] |
There was a problem hiding this comment.
Won't this also pull in web-sys on non-wasm targets? I believe if wasm-client has been enabled then web-sys is already available.
There was a problem hiding this comment.
web-sys is still listed as a dependency for wasm targets only—appears to work as expected this way. actually web-sys is no longer directly used by surf for the wasm-client feature, so we can remove it from there
yoshuawuyts
reviewed
Apr 22, 2020
Comment on lines
-66
to
-78
| "AbortSignal", | ||
| "Headers", | ||
| "ObserverCallback", | ||
| "ReferrerPolicy", | ||
| "Request", | ||
| "RequestCache", | ||
| "RequestCredentials", | ||
| "RequestInit", | ||
| "RequestMode", | ||
| "RequestRedirect", | ||
| "Response", | ||
| "TextDecoder", | ||
| "Window", |
There was a problem hiding this comment.
Oh wow; are these features no longer needed? That's huge!
There was a problem hiding this comment.
They're all specified in http-client :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http-client/*_clientfeatures for curl/wasm/h1.native-clientandh1-clienton CI.