Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove http-service patches #297

Merged
merged 2 commits into from
Jul 26, 2019
Merged

remove http-service patches #297

merged 2 commits into from
Jul 26, 2019

Conversation

yoshuawuyts
Copy link
Member

Signed-off-by: Yoshua Wuyts yoshuawuyts@gmail.com

Description

Removes the http-service patches as a new version has been published.

How Has This Been Tested?

cargo test passes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@taiki-e
Copy link
Contributor

taiki-e commented Jul 26, 2019

@yoshuawuyts
Seems CI failure is the same as rust-lang/futures-rs#1681 (comment).
I believe we can fix this by disabling the cache.
https://github.com/rustasync/tide/blob/3a7601f8a4e1fd171f26114a51d1e852d088adb7/.travis.yml#L3

Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts yoshuawuyts merged commit dfef176 into master Jul 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the remove-patches branch July 26, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants