CORS middleware: better handling of Origin #318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no origin header should be treated as an empty origin header
otherwise, simple HTTP requests like ones made with
curl
will fail with 400 bad requestPretty much any other framework/server treats the absence of an
origin
header the same as emptyorigin
headerDescription
Passing no
origin
header should be treated as an empty origin headerotherwise, simple HTTP requests like ones made with
curl
will fail with 400 bad requestPretty much any other framework/server treats the absence of an
origin
header the same as emptyorigin
headerMotivation and Context
Fixes simple HTTP requests, such as ones made with
curl
How Has This Been Tested?
curl localhost:8000
curl -H 'Origin: something.com' localhost:8000
And to test the cases where it should be rejected, just set the origin to something and then see if any other origin will be rejected
Types of changes
src/middleware.rs
to apply the changeChecklist: