Add Route::all and Route::nest #379

tirr-c · 2019-12-22T06:40:12Z

Follow-up of #364.

Route::all catches all HTTP methods. This is mandatory for nesting story, but I missed this somehow.

This PR also adds a convenience method nest_service, which turns on nesting flag temporarily and calls all.

src/server/route.rs

tests/nested.rs

yoshuawuyts

Looks good! -- few questions, but this should be good to merge either way!

tirr-c · 2020-01-11T07:46:36Z

Renamed the method, and merging!

tirr-c requested a review from yoshuawuyts December 22, 2019 06:40

yoshuawuyts reviewed Dec 24, 2019

View reviewed changes

src/server/route.rs Outdated Show resolved Hide resolved

yoshuawuyts reviewed Dec 24, 2019

View reviewed changes

tests/nested.rs Show resolved Hide resolved

yoshuawuyts approved these changes Dec 24, 2019

View reviewed changes

yoshuawuyts mentioned this pull request Jan 10, 2020

Allow applying middleware before know about request uri and methods http-rs/surf#126

Open

tirr-c added 4 commits January 11, 2020 02:38

Add Route::all and Route::nest_service

50c15f4

Update test to use nest_service

67e10c7

cargo fmt

cccbf03

Rename nest_service to nest

7fcc2b6

tirr-c force-pushed the nest-service branch from be2f31a to 7fcc2b6 Compare January 10, 2020 17:38

tirr-c changed the title ~~Add Route::all and Route::nest_service~~ Add Route::all and Route::nest Jan 11, 2020

tirr-c merged commit 428238c into http-rs:master Jan 11, 2020

tirr-c deleted the nest-service branch January 11, 2020 07:46

Provide feedback