Make Endpoint::call generic over lifetime #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
approved these changes
Jan 31, 2020
| } | ||
|
|
||
| pub(crate) fn add_all(&mut self, path: &str, ep: impl Endpoint<State>) { | ||
| self.all_method_router | ||
| .add(path, Box::new(move |cx| Box::pin(ep.call(cx)))) |
There was a problem hiding this comment.
Oh, getting rid of this is nice!
Comment on lines
+331
to
+340
| impl<State> Clone for Service<State> { | ||
| fn clone(&self) -> Self { | ||
| Self { | ||
| router: self.router.clone(), | ||
| state: self.state.clone(), | ||
| middleware: self.middleware.clone(), | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
What's the difference with the Derive block? It looks like there should be no difference?
There was a problem hiding this comment.
derive block adds State: Clone bound, which is undesirable.
There was a problem hiding this comment.
Oh I thought that bound was intentional. How else do we guarantee that the State can always be cloned for each route?
I feel like I'm missing something here 😅
| @@ -21,7 +17,7 @@ use crate::{Endpoint, Request, Response}; | |||
| /// app.listen("127.0.0.1:8080").await?; | |||
| /// # | |||
| /// # Ok(()) }) } | |||
| /// ```` | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change.
Make
Endpoint::callgeneric over lifetime likeMiddleware::handle.