Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try using routefinder #802

Merged
merged 4 commits into from
Dec 6, 2021
Merged

try using routefinder #802

merged 4 commits into from
Dec 6, 2021

Conversation

jbr
Copy link
Member

@jbr jbr commented Feb 21, 2021

routefinder represents a complete rewrite of the route-recognizer behavior

Breaking changes:

  • there can only be one wildcard per route
  • unnamed params are not supported
  • the prioritization between routes may not be identical in some cases, but there are no known examples of this

There may be an incidental performance improvement of several microseconds per request

closes #783
a step towards #797

@jbr jbr marked this pull request as ready for review February 21, 2021 05:31
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tradeoffs seem reasonable; I'd be in favor of merging this

@Fishrock123
Copy link
Member

@jbr Status of this?

@jbr
Copy link
Member Author

jbr commented Apr 22, 2021

I feel good about this personally, but have hesitations about switching over to it without anyone else playing with it at all, since it's a ground-up rewrite. This is technically a breaking change but I don't have a great sense of how many people would notice any change other than a perf improvement

@Fishrock123
Copy link
Member

Fishrock123 commented Apr 22, 2021

If you can fix the rebase I'll see if I can use it a bit (not quite sure when tho)

@jbr
Copy link
Member Author

jbr commented Apr 22, 2021

@Fishrock123 rebased

@jbr jbr mentioned this pull request May 4, 2021
@Fishrock123 Fishrock123 added the enhancement New feature or request label Aug 12, 2021
@Fishrock123 Fishrock123 added this to the 0.17.0 milestone Aug 12, 2021
Copy link
Member

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel pretty strongly that we should go forward with this as part of a 0.17

@Fishrock123 Fishrock123 merged commit eb33a63 into http-rs:main Dec 6, 2021
@Fishrock123
Copy link
Member

Released as 0.17.0-beta.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to route unknown paths?
3 participants