-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package structure: org.http4s.$role.$backend or org.http4s.$backend.$role #2702
Comments
If ember stands its ground, we'll need to scalafix the heck out of a lot of other things. |
I can't find a single instance of us sharing private server or client components between backends, but many instances in blaze and ember of sharing backend components between server and client. That suggests $backend will also more naturally reflect our repo organization, where I think we should move in this direction, and I know @ChristopherDavenport will be happy. |
#4702 is a good template for this, and we could use some help. |
|
This also has ramifications for the http4s-jdk-http-client project. It doesn't have to change, but it would fit better with the rest. Armeria, Finagle, and Netty all appear to be under the new convention. |
We're targeting series/0.22 with this. Please leave a comment if you're grabbing one. |
I'd like to work on |
Will do this for http4s-jdk-http-client in 0.4 and 0.5 👍 |
@amesgen I wonder whether we should add a scalafix here? That's a little weird to cross repos like that, but it's all binary dependencies in the scalafix project, so it's not really cyclic. |
I'll pick up |
Yes! #4744 for that. |
Doing |
Just to confirm, we still need |
Yep. It would also make sense to move the |
Is |
Feel free to work on it @krayoola 😄 |
What's left? blaze-server, which I missed in the initial checklist? Anything else? |
Ah, I started this but then got confused about the concrete module name. Is it:
? Right now, it is |
We have the same problem with |
I'm taking |
I'd go with |
This discussion originated in the ember PR, but we didn't have a strong consensus. Ember is
org.http4s.ember.client
. Blaze (and all other backends) areorg.http4s.client.blaze
. There are good reasons for both, but I think consistency is better than either argument. Let's standardize on one.Quoting a fool:
The text was updated successfully, but these errors were encountered: