Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move asynchttpclient client package #4749

Merged
merged 4 commits into from Apr 18, 2021

Conversation

vasilmkd
Copy link
Contributor

@vasilmkd vasilmkd commented Apr 14, 2021

Part of #2702.

Depends on #4748 being merged first.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, unless anyone wants to push back on the *client.client bit.

package asynchttpclient
package client
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's a little weird because client is part of the name and it appears twice, but at least it's consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed it too. :/

@rossabaker rossabaker merged commit 8f9d180 into http4s:series/0.22 Apr 18, 2021
@vasilmkd vasilmkd deleted the move-asynchttpclient branch April 18, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants