Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monad[F] constraint on Router.apply #1723

Merged
merged 1 commit into from Mar 22, 2018
Merged

Conversation

@gvolpe
Copy link
Contributor

@gvolpe gvolpe commented Mar 22, 2018

Making Router.apply take just a Monad[F] instead of an unnecessary Sync[F].

Note that Monad is the minimal requirement. Internal function translate requires only a Functor but it seems the Kleisli instance for SemigroupK requires a Monad and <+> is being used to combine HttpServices.

Discussed it a bit on on Gitter with @jmcardon.

@aeons
aeons approved these changes Mar 22, 2018
Copy link
Member

@aeons aeons left a comment

I bet there are a lot of these floating around in the codebase.

Copy link
Member

@jmcardon jmcardon left a comment

Cool with me.

👍 on green

@ChristopherDavenport ChristopherDavenport merged commit 57053b9 into http4s:master Mar 22, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rossabaker rossabaker mentioned this pull request Apr 20, 2018
19 of 31 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants