Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monad[F] constraint on Router.apply #1723

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Monad[F] constraint on Router.apply #1723

merged 1 commit into from
Mar 22, 2018

Conversation

gvolpe
Copy link
Contributor

@gvolpe gvolpe commented Mar 22, 2018

Making Router.apply take just a Monad[F] instead of an unnecessary Sync[F].

Note that Monad is the minimal requirement. Internal function translate requires only a Functor but it seems the Kleisli instance for SemigroupK requires a Monad and <+> is being used to combine HttpServices.

Discussed it a bit on on Gitter with @jmcardon.

aeons
aeons approved these changes Mar 22, 2018
View reviewed changes
Copy link
Member

@aeons aeons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet there are a lot of these floating around in the codebase.

jmcardon
jmcardon approved these changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@jmcardon jmcardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool with me.

👍 on green

@ChristopherDavenport ChristopherDavenport merged commit 57053b9 into http4s:master Mar 22, 2018
@rossabaker rossabaker mentioned this pull request Apr 20, 2018
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeons aeons aeons approved these changes

@ChristopherDavenport ChristopherDavenport ChristopherDavenport approved these changes

@jmcardon jmcardon jmcardon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gvolpe @aeons @ChristopherDavenport @jmcardon