New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port multipart goodness to to 0.18.x branch #1727

Merged
merged 5 commits into from Mar 23, 2018

Conversation

Projects
None yet
3 participants
@jmcardon
Member

jmcardon commented Mar 23, 2018

:D

@jmcardon jmcardon requested a review from rossabaker Mar 23, 2018

@jmcardon

This comment has been minimized.

Member

jmcardon commented Mar 23, 2018

seems to pass all tests, but trying it on a small client I cannot get it to run properly, so I'm double checking first if there is a problem was bugged

@jmcardon

This comment has been minimized.

Member

jmcardon commented Mar 23, 2018

Bugs have been fixed, and tested with postman. See notes on #1728.

@rossabaker

This comment has been minimized.

Member

rossabaker commented Mar 23, 2018

Wait a second, what's the difference between this and #1728 other than target branch? Aren't we just going to roll this one into master once merged?

@jmcardon

This comment has been minimized.

Member

jmcardon commented Mar 23, 2018

@rossabaker mostly that the #1728 version doesnt deprecate the other stuff for the sake of MiMa, it straight up deletes the old version.

@rossabaker

This comment has been minimized.

Member

rossabaker commented Mar 23, 2018

Yeah, it's going to have to to get rid of that dependency. I am pro-deprecation until it exerts drag, like pulling in a new dependency.

Okay, merging this one, will roll forward, and will use #1728 as a guideline if the merge is ugly.

@rossabaker rossabaker merged commit 408bcec into http4s:release-0.18.x Mar 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment