-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port multipart goodness to to 0.18.x branch #1727
Conversation
|
Bugs have been fixed, and tested with postman. See notes on #1728. |
Wait a second, what's the difference between this and #1728 other than target branch? Aren't we just going to roll this one into master once merged? |
@rossabaker mostly that the #1728 version doesnt deprecate the other stuff for the sake of MiMa, it straight up deletes the old version. |
Yeah, it's going to have to to get rid of that dependency. I am pro-deprecation until it exerts drag, like pulling in a new dependency. Okay, merging this one, will roll forward, and will use #1728 as a guideline if the merge is ugly. |
:D