Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove httpbin.org dependency from client tests #1836

Merged
merged 1 commit into from
May 9, 2018
Merged

Remove httpbin.org dependency from client tests #1836

merged 1 commit into from
May 9, 2018

Conversation

rossabaker
Copy link
Member

This is bad code but gets us back in business. Unit tests have been failing today because httpbin.org is down.

We should look for an embedded server that's:

  1. easy to set up
  2. easy to set up with SSL
  3. isn't ours, so we don't have circular dependencies

The Jetty scaffold only ticks boxes 1 and 3.

@rossabaker rossabaker added testing Issues related to tests CI Relates to the health of our builds labels May 9, 2018
This was referenced May 9, 2018
Merged
Merged
@rossabaker rossabaker force-pushed the remove-httpbin-test-dep branch 2 times, most recently from f61738f to 64e2a3f Compare May 9, 2018 12:39
@rossabaker rossabaker changed the base branch from master to release-0.18.x May 9, 2018 13:31
@rossabaker
Copy link
Member Author

CI failure is ongoing Travis networking issue.

ChristopherDavenport
ChristopherDavenport approved these changes May 9, 2018
View reviewed changes
Copy link
Member

@ChristopherDavenport ChristopherDavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugly, but better than yesterday's ugliness.

@rossabaker rossabaker merged commit cd5c128 into http4s:release-0.18.x May 9, 2018
@rossabaker rossabaker deleted the remove-httpbin-test-dep branch May 9, 2018 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherDavenport ChristopherDavenport ChristopherDavenport approved these changes

Assignees
No one assigned
Labels
CI Relates to the health of our builds testing Issues related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossabaker @ChristopherDavenport