Reinstate examples #2139
Merged
Reinstate examples #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeons
force-pushed
the
reinstate-examples
branch
from
faeb1bd
to
591058f
Compare
rossabaker
approved these changes
Oct 2, 2018
| @@ -37,6 +38,6 @@ object ClientMultipartPostExample extends IOApp with Http4sClientDsl[IO] { | |||
| def run(args: List[String]): IO[ExitCode] = | |||
| BlazeClientBuilder[IO](global).resource | |||
| .use(go) | |||
| .flatMap(s => IO(println)) | |||
| .flatMap(s => IO(println(s))) | |||
| @@ -19,7 +19,7 @@ class GitHubService[F[_]: Sync](client: Client[F]) extends Http4sClientDsl[F] { | |||
|
|
|||
| private val RedirectUri = s"http://localhost:8080/$ApiVersion/login/github" | |||
|
|
|||
| final case class AccessTokenResponse(access_token: String) | |||
| case class AccessTokenResponse(access_token: String) | |||
There was a problem hiding this comment.
I like the final on case classes. It doesn't matter much here, but it's a good habit.
There was a problem hiding this comment.
Yeah, me too, but this one doesn't compile if it's final :)
|
|
||
| logger.trace(s"Adding push resource: $newUrl") | ||
| final class PushOps[F[_]: Functor](response: Response[F]) extends AnyRef { |
There was a problem hiding this comment.
Yes, this change makes a lot more sense.
rossabaker
added a commit
to http4s/http4s-servlet
that referenced
this pull request
Apr 3, 2022
Reinstate examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2107
Updated and re-enabled all the example projects.
There's less inheritance now, and everything should use
F[_]all the way up toIOApp.The examples are not 100% consistent with each other.
I updated the push support syntax to operate on
Response[F]instead ofF[Response[F]], to be in line with the syntax on response and request. I did not add a deprecated copy of the old behaviour. I can add that if you guys want it.