Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Baseline Transition for Vault Use #2318
rossabaker left a comment
So, there's the issue with the trailer headers, which seems independent of
A second comment is about Vault itself: much of this diff is changes of method names from those inspired by
Finally, to this PR itself: the keys are always
I don't see a need for vault to change, but could make java/scala style methods as well which could reduce additional noise.
I don't mind doing the work here after the other PR's are all in with changes to attribute maps.
As far as the fact that it currently only does it this way, that was intentional. I wanted to sign the waiver to start off with, but later we could make middlewares return tuples with the key to extract the values generated by that middleware etc, which I believe would often be a better pattern. However I thought that the minimal piece was ideal.
As per the library dependency. Utilizing a shared tool means that this can and will translate with other peoples vault use. Where as an internal one means that conversions would be required to work with the library.
I think it has value, but do understand the reticence.