Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebjarService: Simplify code #2542

Merged
merged 1 commit into from May 28, 2019

Conversation

@diesalbla
Copy link
Contributor

commented May 2, 2019

  • Replace OptionT methods with direct style (function calls) and
    pattern matching, using the Option type most of the time.
  • Replace Option.map and Option.collect by pattern-matching on Option ADT.

@diesalbla diesalbla force-pushed the diesalbla:webjarservice_simplify branch from c19522e to 7e6c348 May 2, 2019

@rossabaker
Copy link
Member

left a comment

I don't find it any easier to read, but it saves a few allocations. Mild 👍

@diesalbla diesalbla force-pushed the diesalbla:webjarservice_simplify branch from 7e6c348 to 229012b May 15, 2019

@diesalbla

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

I have changed the code a little bit, to spread it vertically, and also to fix a non-exhaustive match.

qWebjarService: Simplify code
- Replace OptionT methods with direct style (function calls) and
   pattern matching, using the `Option` type most of the time.

@diesalbla diesalbla force-pushed the diesalbla:webjarservice_simplify branch from 229012b to e226816 May 22, 2019

@rossabaker rossabaker merged commit 43f2461 into http4s:master May 28, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@diesalbla diesalbla deleted the diesalbla:webjarservice_simplify branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.