Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Tomcat SSL config, deprecate abandoned ServerBuilder #3140

Merged
merged 3 commits into from
Feb 3, 2020
Merged

Refactor Tomcat SSL config, deprecate abandoned ServerBuilder #3140

merged 3 commits into from
Feb 3, 2020

Conversation

rossabaker
Copy link
Member

@rossabaker rossabaker commented Feb 1, 2020 •
edited
Loading

  • Refactors the Tomcat SSL configuration
  • Lets us deprecate types from the ServerBuilder not in the public API
  • Deprecated JettyBuider.withSSL, like Blaze's. Tomcat doesn't currently have an alternative.
  • Tomcat still falls short of the other four backends in being able to use SSLParameters or fs2's TLSParameters. 🤷

@rossabaker rossabaker added this to the 0.21.0-RC3 milestone Feb 1, 2020
@rossabaker rossabaker added the breaking Change breaks compatibility (binary or source) label Feb 1, 2020
rossabaker
rossabaker commented Feb 1, 2020
View reviewed changes
tomcat/src/main/scala/org/http4s/server/tomcat/TomcatBuilder.scala
conn.setScheme("https")
conn.setAttribute("SSLEnabled", true)

// TODO These configuration properties are all deprecated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to fix this, but it no longer bound the port.

@rossabaker rossabaker merged commit 29ccdf6 into http4s:master Feb 3, 2020
@rossabaker rossabaker mentioned this pull request Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamnis hamnis hamnis approved these changes

@ChristopherDavenport ChristopherDavenport ChristopherDavenport approved these changes

Assignees
No one assigned
Labels
breaking Change breaks compatibility (binary or source)
Projects
None yet
Milestone
0.21.0-RC3
Development

Successfully merging this pull request may close these issues.
3 participants
@rossabaker @hamnis @ChristopherDavenport