Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Streamed encoder for empty stream #3906

Closed
wants to merge 2 commits into from

Conversation

peterneyens
Copy link
Contributor

Follow up of #3891.

It seems we aren't emiting the opening [ when the stream is empty.

@JesusMtnez
Copy link

Thank you @peterneyens for the quick fix!

@rossabaker rossabaker added the bug Determined to be a bug in http4s label Nov 23, 2020
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Good find. Let's cherry-pick this back to 0.21 and get a patch out ASAP.

@rossabaker rossabaker added the retarget Cherry-pick or reopen on another branch label Nov 23, 2020
@rossabaker
Copy link
Member

Cherry-picked onto 0.21.

@rossabaker rossabaker closed this Nov 24, 2020
@peterneyens peterneyens deleted the patch-1 branch November 24, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Determined to be a bug in http4s retarget Cherry-pick or reopen on another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants