Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-3946 Activate and migrate play-json to Cats-effect 3 #3962

Merged
merged 1 commit into from
Nov 28, 2020
Merged

Issue-3946 Activate and migrate play-json to Cats-effect 3 #3962

merged 1 commit into from
Nov 28, 2020

Conversation

amiguez
Copy link
Contributor

@amiguez amiguez commented Nov 28, 2020 •
edited
Loading

As discussed with @rossabaker. Use Concurrent instead of Sync in the play-json module. Issue: #3962

rossabaker
rossabaker approved these changes Nov 28, 2020
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on green

@rossabaker
Copy link
Member

Docs failure is unrelated.

@rossabaker rossabaker merged commit ced4dd2 into http4s:cats-effect-3 Nov 28, 2020
@rossabaker rossabaker mentioned this pull request Nov 28, 2020
Closed
@amiguez amiguez deleted the issue-3946-playjson-ce3 branch August 7, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker rossabaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amiguez @rossabaker