Allow For Providing HttpConfiguration With Jetty #4032
Conversation
This commit makes two meaningful changes, * Allow for the user to provide their own `HttpConfiguration` value. This is important as there are many settings which are not modeled in the `JettyBuilder` that one would general expect to have access to. * Enforces that the `HttpConfiguration` is used whether or not http2 is enabled. Formerly the `HttpConfiguration` was only used if there was not an `SslConnectionFactory` and http2 support was enabled.
There was a problem hiding this comment.
I like it.
I've thought it would be nice to provide an alternate builder that just took a Jetty instance and wrapped it in the typical server trappings. This would allow the more exotic parts of the API our builder doesn't cover. But I think this is good for what we do today.
| @@ -400,6 +444,10 @@ object JettyBuilder { | |||
| case SSLClientAuthMode.Required => | |||
| sslContextFactory.setNeedClientAuth(true) | |||
| } | |||
|
|
|||
| /** The default [[org.eclipse.jetty.server.HttpConfiguration]] to use with jetty. */ | |||
| val defaultJettyHttpConfiguration: HttpConfiguration = | |||
There was a problem hiding this comment.
Does this need to be public? I guess we're already committed to supporting anHttpConfiguration on the API, so the additional liability isn't much. I could go either way here.
There was a problem hiding this comment.
@rossabaker I made it public so that someone who wants to make a minor adjustment to the configuration can do so and then just use the rest of the "default" http4s configuration. Of course, since our default configuration right now is just the empty constructor, that doesn't really make a lot of sense.
I am going to make another PR which attempts to align the various configuration parameters which can be meaningfully shared between server backends, e.g. request header size etc. I'll make this private until that PR.
This commit makes two meaningful changes,
HttpConfigurationvalue. This is important as there are many settings which are not modeled in theJettyBuilderthat one would general expect to have access to.HttpConfigurationis used whether or not http2 is enabled. Formerly theHttpConfigurationwas only used if there was not anSslConnectionFactoryand http2 support was enabled.