Postpone using Query model until we need it #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updating the test to just reflect that we pass on the brackets, then this will pass. |
…lowed in the spec
hamnis
requested review from
rossabaker and
m-sp
and removed request for
rossabaker
|
Also deals with #2445 |
m-sp
approved these changes
Apr 13, 2021
ChristopherDavenport
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make #1813 #3277 and #3233 work better on 0.22+.
I think this also was done on 0.21 a while ago, must have been lost in the parsing update.
The test failure assumes that we encode the
[]brackets. this change would then pass them through, since we have allowed them in the parser.