Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postpone using Query model until we need it #4739

Merged
merged 2 commits into from Apr 13, 2021
Merged

Postpone using Query model until we need it #4739

merged 2 commits into from Apr 13, 2021

Conversation

hamnis
Copy link
Contributor

@hamnis hamnis commented Apr 12, 2021

Should make #1813 #3277 and #3233 work better on 0.22+.
I think this also was done on 0.21 a while ago, must have been lost in the parsing update.

The test failure assumes that we encode the [] brackets. this change would then pass them through, since we have allowed them in the parser.

@hamnis
Copy link
Contributor Author

hamnis commented Apr 12, 2021

Updating the test to just reflect that we pass on the brackets, then this will pass.

@hamnis hamnis requested review from rossabaker and m-sp and removed request for rossabaker April 12, 2021 07:39
@hamnis hamnis added the uri raze it and salt the earth whence it grew label Apr 12, 2021
@hamnis
Copy link
Contributor Author

hamnis commented Apr 13, 2021

Also deals with #2445

@rossabaker rossabaker merged commit e1854e3 into http4s:series/0.22 Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
uri raze it and salt the earth whence it grew
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants