Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala 3.0.0 #4830

Merged
merged 9 commits into from
May 19, 2021
Merged

Scala 3.0.0 #4830

merged 9 commits into from
May 19, 2021

Conversation

rossabaker
Copy link
Member

@rossabaker rossabaker commented May 16, 2021 •
edited by aeons
Loading

@rossabaker
Copy link
Member Author

Some nonsense about this:

[error] (update) sbt.librarymanagement.ResolveException: Error downloading org.scala-lang:scala3-library_3.0.0:3.0.0
[error]   Not found
[error]   Not found
[error]   not found: /home/ross/.ivy2/local/org.scala-lang/scala3-library_3.0.0/3.0.0/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/org/scala-lang/scala3-library_3.0.0/3.0.0/scala3-library_3.0.0-3.0.0.pom
[error]   not found: https://jcenter.bintray.com/org/scala-lang/scala3-library_3.0.0/3.0.0/scala3-library_3.0.0-3.0.0.pom

We're blocked on a final release without a Circe release.

@rossabaker rossabaker added this to the 0.22 milestone May 16, 2021
@rossabaker rossabaker mentioned this pull request May 17, 2021
Merged
@kevin-lee
Copy link
Contributor

This org.scala-lang/scala3-library_3.0.0/3.0.0 should be org.scala-lang/scala3-library_3/3.0.0. It might be because of some plugin used by http4s.
I don't think you need sbt-dotty anymore. Could you try sbt 1.5.2 instead? Or let me see if I can help anything after work today.

@aeons
Copy link
Member

aeons commented May 17, 2021

PRs up for case-insensitive and vault.

I hit the same issue where something pulls in an old version of sbt-dotty which makes resolution fail.

@aeons
Copy link
Member

aeons commented May 17, 2021 •
edited
Loading

PR for blaze is up, but it's missing a log4s dependency.

@kevin-lee
Copy link
Contributor

@aeons I think it will be released soon.

@aeons
Copy link
Member

aeons commented May 17, 2021

Yes, I linked to that from the blaze PR :)

There might be an issue with the build pipeline though, since the RC Ross made yesterday is not on maven central.

@aeons
Copy link
Member

aeons commented May 17, 2021

The PR I made for vault was for the CE3 branch. Now there's one for the CE2 branch as well: typelevel/vault#234

That depends on a release of unique though: typelevel/unique#191

@aeons
Copy link
Member

aeons commented May 17, 2021 •
edited
Loading

There should be PRs up for all dependencies now.
For the CE2 branches at least.

@aeons
Copy link
Member

aeons commented May 17, 2021

All that's missing now are releases of vault and blaze.

@kevin-lee
Copy link
Contributor

I think vault is available now but I get this when I sbt compile on my local machine.

[error] Symbol 'type org.http4s.jawn.JawnInstances' is missing from the classpath.
[error] This symbol is required by 'package org.http4s.jawn.package'.
[error] Make sure that type JawnInstances is in your classpath and check for conflicting dependencies with `-Ylog-classpath`.
[error] A full rebuild may help if 'package.class' was compiled against an incompatible version of org.http4s.jawn.
[error] one error found
[error] stack trace is suppressed; run last blaze-core / update for the full output
[error] (jawn / Compile / compileIncremental) Compilation failed
[error] (blaze-core / update) sbt.librarymanagement.ResolveException: Error downloading org.http4s:blaze-http_2.13:0.15.0

@rossabaker
Copy link
Member Author

jawn is weirdness from package object inheritance, and a clean should fix that.

I'll check on the blaze release.

@rossabaker
Copy link
Member Author

http4s/blaze#505 ate blaze despite an attempted fix. I'm just publishing it manually from the tag.

@kevin-lee
Copy link
Contributor

@rossabaker Thanks! Yeah I also just found that blaze-http 0.15.0 is not released.

@rossabaker rossabaker mentioned this pull request May 18, 2021
Merged
@kevin-lee
Copy link
Contributor

Some nonsense about this:

[error] (update) sbt.librarymanagement.ResolveException: Error downloading org.scala-lang:scala3-library_3.0.0:3.0.0
[error]   Not found
[error]   Not found
[error]   not found: /home/ross/.ivy2/local/org.scala-lang/scala3-library_3.0.0/3.0.0/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/org/scala-lang/scala3-library_3.0.0/3.0.0/scala3-library_3.0.0-3.0.0.pom
[error]   not found: https://jcenter.bintray.com/org/scala-lang/scala3-library_3.0.0/3.0.0/scala3-library_3.0.0-3.0.0.pom

We're blocked on a final release without a Circe release.

@rossabaker Just FYI, I think I found the reason why this happened.
When I do show scalaBinaryVersion, I get 3.0.0 but it should be 3. I found one of the plugins used in http4s overrides it.
I think It's dotty.tools.sbtplugin.DottyPlugin used by SpiewakPlugin. I can see the DottyPlugin was dropped from sbt-spiewak but I don't think the new one was released yet.

@aeons
Copy link
Member

aeons commented May 18, 2021 •
edited
Loading

Yeah, that's the issue. sbt-spiewak pulls in an older sbt-dotty that doesn't work with 3.0.0 final. So we need to readd the newest sbt-dotty that works with 3.0.0.

I created djspiewak/sbt-spiewak#55

@aeons
Copy link
Member

aeons commented May 18, 2021

It now fails on the unusedCompileDependenciesTest with a lot of false positives.

[warn] scalatags >>> The following libraries are declared in libraryDependencies but are not needed for compilation:
[warn]  - "com.lihaoyi" % "scalatags" % "0.9.4"
[warn] boopickle >>> The following libraries are declared in libraryDependencies but are not needed for compilation:
[warn]  - "io.suzaku" % "boopickle" % "1.3.3"
[warn] twirl >>> The following libraries are declared in libraryDependencies but are not needed for compilation:
[warn]  - "com.typesafe.play" % "twirl-api" % "1.5.1"
[warn] play-json >>> The following libraries are declared in libraryDependencies but are not needed for compilation:
[warn]  - "com.typesafe.play" % "play-json" % "2.10.0-RC2"
[error] (play-json / unusedCompileDependenciesTest) Failing the build because unused dependencies were found
[error] (twirl / unusedCompileDependenciesTest) Failing the build because unused dependencies were found
[error] (scalatags / unusedCompileDependenciesTest) Failing the build because unused dependencies were found
[error] (boopickle / unusedCompileDependenciesTest) Failing the build because unused dependencies were found

@kevin-lee
Copy link
Contributor

kevin-lee commented May 18, 2021 •
edited
Loading

It doesn't look like GitHub Actions is functioning (again 😔).
The workflow jobs don't start.

@aeons
Copy link
Member

aeons commented May 18, 2021

Yeah, I have tried canceling and restarting a couple of times.

@rossabaker
Copy link
Member Author

Oh, the unused compile dependencies are the things we use withDottyCompat for so we can compile them until there's a proper release. I'll change it to opt out on the Scala 3 build. That check has saved us from bugs a few times, and I'd really like to keep it.

@aeons
Copy link
Member

aeons commented May 18, 2021 •
edited
Loading

Yeah, it is already disabled on scala 3. The errors showed on 2.12 and 2.13.

@rossabaker
Copy link
Member Author

Oh. Well, nuts. Hopefully it's only a temporary thing, then.

@aeons
Copy link
Member

aeons commented May 18, 2021 •
edited
Loading

The remaining build failures now are the moved blaze client stuff in docs that are fixed in #4844, so I guess this is good to go.
@rossabaker

@rossabaker rossabaker merged commit f53eba7 into series/0.22 May 19, 2021
@rossabaker rossabaker deleted the scala-3 branch May 19, 2021 03:55
@kevin-lee
Copy link
Contributor

@rossabaker I'm not sure if it's actually an issue but I got this when I tested this branch locally. #4848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.22
Development

Successfully merging this pull request may close these issues.
3 participants
@rossabaker @kevin-lee @aeons