Update Origin header #5082
Merged
Update Origin header #5082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
reviewed
Aug 17, 2021
| // If the Origin is not "null", it is a non-empty list of Hosts: | ||
| // http://tools.ietf.org/html/rfc6454#section-7 | ||
| final case class HostList(hosts: NonEmptyList[Host]) extends Origin | ||
| case object `null` extends Origin |
There was a problem hiding this comment.
I can't think of another case that we modeled the header as a sum type instead of a unary case class of a sum type, but I think I like it. It sidesteps the org.http4s.Origin vs. org.http4s.header.Origin debate. And it slipped through review the first time without me noticing!
| test("OriginHeader parser should Parse an empty origin") { | ||
| val text = "" | ||
| val origin = Origin.Null | ||
| test("OriginHeader should fail on a list of multiple hosts") { |
There was a problem hiding this comment.
Might be worth a comment referring to the obsolete RFC here.
| test("OriginHeader parser should Parse a 'null' origin") { | ||
| val text = "null" | ||
| val origin = Origin.Null | ||
| test("OriginHeader should fail on an empty string") { |
There was a problem hiding this comment.
I'm thinking about whether this a bug we should backport, or a breaking change we shouldn't backport. But it's certainly right for this version.
There was a problem hiding this comment.
I'd say the former, but I don't think it's super important.
rossabaker
approved these changes
Aug 30, 2021
rossabaker
added a commit
that referenced
this pull request
Aug 30, 2021
rossabaker
added a commit
that referenced
this pull request
Sep 2, 2021
Backport empty Origin failure from #5082
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5009.
I've also taken the opportunity to backtify the
nullvalue for consistency with the rest of the library, to stop parsing empty values asnull(it's not allowed by the spec), and generally to simplify the parsing implementation.