Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Bootstrap 5 #5204

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Update to Bootstrap 5 #5204

merged 1 commit into from
Sep 17, 2021

Conversation

noelwelsh
Copy link

  • Replace Bootstrap 4 with Bootstrap 5

  • Change formatting to approximate existing site. I'm not aiming to 100%
    matching the existing styling as I think we'll change aspect of it
    anyway. Just get something close enough without too much work.

  • Close Update Bootstrap to 5.1.1 #5191

@noelwelsh
First pass at updating to Bootstrap 5
6d645c7 
- Replace Bootstrap 4 with Bootstrap 5

- Change formatting to approximate existing site. I'm not aiming to 100%
matching the existing styling as I think we'll change aspect of it
anyway. Just get something close enough without too much work.
@noelwelsh noelwelsh changed the title First pass at updating to Bootstrap 5 Update to Bootstrap 5 Sep 17, 2021
@rossabaker
Copy link
Member

  • partials/head.html is including the bootstrap that you upgraded, and partials/scripts.html is including one from bootstrapcdn.com, and I'm surprised we have two. This is a pre-existing condition, but I don't know whether it foils any of your plans.

  • Something happened to the icons in the top right:
    Screen Shot 2021-09-17 at 3 22 29 PM

rossabaker
rossabaker approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ope, those icons are broken locally on main, too. I think that's unrelated to this.

@rossabaker rossabaker merged commit ac2dd30 into http4s:main Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker rossabaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Bootstrap to 5.1.1
2 participants
@noelwelsh @rossabaker