Non-trivial merge to 0.23 #5506
Conversation
Thin ci matrix
Sec-Fetch-Dest header
Port #5477 to the series/0.22
Remove redundant setting in scalafix build
Remove redundant val in the `Header.Raw` constructor
Fix `scaladoc` for some `Headers` methods
Fix Origin parsing on hosts starting with a number
|
A bunch of jobs got kill -9'ed. Restarting to see if it was a GitHub flake. |
|
And the build matrix isn't as spare as it ought to be. |
|
Just re-triggered it and same deal. Any idea what's going on here? |
|
Ah, I know what's going on. The ci thing which segregates JVM/JS builds in the matrix went missing. So now it's trying to do both at the same time and Scala.js linking step is extremely memory-intensive. So GH is killing the job. |
| @@ -65,27 +77,27 @@ jobs: | |||
|
|
|||
| - name: Check formatting | |||
| if: matrix.scala != '3.1.0' | |||
| run: sbt ++${{ matrix.scala }} '${{ matrix.ci }}' scalafmtCheckAll | |||
There was a problem hiding this comment.
This ${{ matrix.ci }} is what was used to to set the root project to either rootJVM or rootJS.
There was a problem hiding this comment.
I doubt Ross would mind if you felt like pushing a fix 😄
There was a problem hiding this comment.
Oh, something in the merge made it look like that had been intentionally removed, and I didn't understand it, so I played along.
|
Nice green checkmark for a build so broken that didn't run at all. |
No description provided.