Make Node.js interop APIs private #6404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rossabaker
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially intended to make these APIs public since they are helpful for integrating with serverless frameworks. After thinking more, I changed my mind.
Besides these interop APIs, there is essentially nothing else JS-specific in http4s, and I think that's great.
Furthermore, the only reason we need these interop APIs in http4s at all is to implement the Node.js scaffold server for the client testkit. I'd like to reserve the option to remove the need for them completely in the future: for example, by running the scaffold server as an external process via sbt (i.e., a testkit distributed as an sbt plugin).