Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the internal package of unused/deprecated things #7158

Merged
merged 1 commit into from Jun 21, 2023

Conversation

froth
Copy link
Member

@froth froth commented Jun 14, 2023

This removes some of the things mentioned in #7031.

I could also replace hashLower in the whole repo as suggested in the comment. This could be done by using CIString for class TransferCoding and class Scheme which would be correct according to RFC, but breaking.

@mergify mergify bot added the module:core label Jun 14, 2023
@froth
Copy link
Member Author

froth commented Jun 14, 2023

private[http4s] def compareField[A, B: Order] is only used in Uri. Could be moved there and made private. Opinions on that?

@armanbilge
Copy link
Member

This could be done by using CIString for class TransferCoding and class Scheme which would be correct according to RFC, but breaking.

That sounds right, maybe deserves its own dedicated PR?

private[http4s] def compareField[A, B: Order] is only used in Uri. Could be moved there and made private. Opinions on that?

Sounds good to me 👍 then we can merge this one.

@froth
Copy link
Member Author

froth commented Jun 15, 2023

This could be done by using CIString for class TransferCoding and class Scheme which would be correct according to RFC, but breaking.

That sounds right, maybe deserves its own dedicated PR?

Yeah, that sounds right.

private[http4s] def compareField[A, B: Order] is only used in Uri. Could be moved there and made private. Opinions on that?

Sounds good to me +1 then we can merge this one.

After having another look at compareField: it is just wrapped again in these cases. I simply replaced by Order.by[A, B](f).compare(a, b) and deleted compareField. Updating Pull request when lint is happy.

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@froth
Copy link
Member Author

froth commented Jun 17, 2023

I had some arguments with git while rebasing and in the process pushed a wrong commit. I fixed that but accidentally brought mergify to add module:laws module:ember-core module:circe labels. This PR does not involve these modules. Sorry...

@danicheg danicheg merged commit 8951e66 into http4s:main Jun 21, 2023
13 checks passed
froth pushed a commit to froth/http4s that referenced this pull request Jun 21, 2023
Clear the internal package of unused/deprecated things
@froth froth deleted the 7031 branch June 21, 2023 15:12
@armanbilge armanbilge added the behind-the-scenes Appreciated, but not user-facing label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behind-the-scenes Appreciated, but not user-facing module:core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants