New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear the internal package of unused/deprecated things #7158
Conversation
|
That sounds right, maybe deserves its own dedicated PR?
Sounds good to me 👍 then we can merge this one. |
Yeah, that sounds right.
After having another look at compareField: it is just wrapped again in these cases. I simply replaced by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
5d02043
to
dcf0634
Compare
I had some arguments with git while rebasing and in the process pushed a wrong commit. I fixed that but accidentally brought mergify to add module:laws module:ember-core module:circe labels. This PR does not involve these modules. Sorry... |
Clear the internal package of unused/deprecated things
This removes some of the things mentioned in #7031.
I could also replace
hashLower
in the whole repo as suggested in the comment. This could be done by using CIString forclass TransferCoding
andclass Scheme
which would be correct according to RFC, but breaking.