Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Uri.Scheme and TransferCoding to CIString #7164

Merged
merged 2 commits into from Jun 17, 2023
Merged

Migrate Uri.Scheme and TransferCoding to CIString #7164

merged 2 commits into from Jun 17, 2023

Conversation

froth
Copy link
Member

@froth froth commented Jun 15, 2023 •
edited

Follow up on #3442 and #7158. Fixes parts of #7031.

Replaced internal case insensitive implementation with CIString

@froth froth force-pushed the CIString branch 3 times, most recently from 42423b6 to 7183cb6 Compare June 15, 2023 13:11
@armanbilge armanbilge changed the title Migrate Uri.Scheme and TransferCoding to CIString Migrate Uri.Scheme and TransferCoding to CIString Jun 15, 2023
armanbilge
armanbilge approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is much better!

danicheg
danicheg reviewed Jun 16, 2023
View reviewed changes
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Like this PR generally, just a few comments

core/shared/src/main/scala/org/http4s/TransferCoding.scala Outdated Show resolved Hide resolved
tests/shared/src/test/scala/org/http4s/SchemeSuite.scala Outdated Show resolved Hide resolved
tests/shared/src/test/scala/org/http4s/TransferCodingSpec.scala Outdated Show resolved Hide resolved
armanbilge
armanbilge approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danicheg
Copy link
Member

Nice job, thanks again!

@danicheg danicheg merged commit 88e06db into http4s:main Jun 17, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danicheg danicheg danicheg left review comments

@hamnis hamnis hamnis approved these changes

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
module:circe module:client module:core module:ember-core module:laws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@froth @danicheg @hamnis @armanbilge