Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prescriptive RhoRoutes logger #607

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Remove prescriptive RhoRoutes logger #607

merged 1 commit into from
Sep 5, 2022

Conversation

blmeadows
Copy link
Contributor

update for #606

@zarthross
Copy link
Member

Thanks for the PR! This is binary breaking so it'll have to wait for the next bin-incompat release.

@FrancescoSerra
Copy link
Contributor

Considering that now main target the 1.0.0-M* series, which has no bin-compat guarantees, I think this should be fine to merge. @zarthross thoughts?

@zarthross zarthross merged commit 17f4c91 into http4s:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarthross zarthross zarthross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blmeadows @zarthross @FrancescoSerra