Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Release cleanups and fixes #120

Merged
merged 6 commits into from
Apr 3, 2014
Merged

[HOTFIX] Release cleanups and fixes #120

merged 6 commits into from
Apr 3, 2014

Conversation

ixti
Copy link
Member

@ixti ixti commented Apr 3, 2014

  • Make Client#perform single shot again
  • Fix request query params merge/injection
  • Add specs for requests params merge fix

@@ -1,2 +1,2 @@
require 'http/backports/uri'
require 'http/backports/base64'
require 'http/backports/uri' if RUBY_VERSION < '1.9.3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scumbag 1.9.2 😢

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record, pasting here same I shared on IRC :D

URI.decode URI.encode_www_form :a => [1,2]

On Ruby >= 1.9.3, this outputs: a=1&b=2, which is pretty expected, on Ruby = 1.9.2 it outputs something absolutely insane: a=[1,+2]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will note that 1.9.2 is widely considered to be broken in general. This is patching 1.9.2's URI.encode_www_form to have a non-broken behavior. If people are depending on the broken behaviors of a broken Ruby VM, this could be a potentially breaking change. I'm not sure how much I care about breaking the code of people depending on the broken behaviors of a broken VM, however. I would personally prefer to drop support for 1.9.2 entirely.

tarcieri added a commit that referenced this pull request Apr 3, 2014
[HOTFIX] Release cleanups and fixes
@tarcieri tarcieri merged commit 7b63f7e into master Apr 3, 2014
@tarcieri tarcieri deleted the fix/release-fixes branch April 3, 2014 02:19
@tarcieri
Copy link
Member

tarcieri commented Apr 3, 2014

👍 :shipit:

@tarcieri tarcieri mentioned this pull request Apr 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants