Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 0.6.0 #65

Closed
schmurfy opened this issue Jan 24, 2014 · 21 comments
Closed

Release version 0.6.0 #65

schmurfy opened this issue Jan 24, 2014 · 21 comments
Milestone

Comments

@schmurfy
Copy link

You should definetely make a release, there is such a large gap between 0.5.0 and master it looks like a completely different library, even if there are issues left in master it is worth pushing a release out I think since 0.5.0 has issues of its own anyway xD

is there any major issue preventing a release ?

@sferik
Copy link
Contributor

sferik commented Jan 24, 2014

Before we can ship a new version, I’d like to see JSON parsing reimplemented (it was temporarily removed in #64). I would also like to see proper proxy support (a broken implementation was removed in #62), but this is not as important.

As far as I know, those are the last couple issues holding up a new gem release. I’ve created a v0.6 milestone to make it easier to track blockers and added this issue to it. @tarcieri may add other issues that he’d like to see implemented before the release to this milestone.

@schmurfy
Copy link
Author

ok I will stick to master for now then, after this I think you should consider releasing more often since what new users will see is not the awesome new features that are lying on master but, in this case, a library which works more or less as intended or not at all depending on their use case and they will move on trying something else that may work.

In my case seeing how badly the library handled the http responses from influxdb I just had to go back to the non celluloid library giving up fiber concurrency offered by celluloid-io (I could not simply spawn a pool of actors in that case).

I already saw that many times in open source projects where big features are kept away because of the fear of releasing a new version.

Anyway this library is really nice !

@blambeau
Copy link
Contributor

#46 should probably be fixed too before releasing, IMHO.

@sferik
Copy link
Contributor

sferik commented Jan 24, 2014

@blambeau I’ve added it to the v6 milestone.

@tarcieri
Copy link
Member

@schmurfy the reason we haven't done a release lately is because we're trying to one last release of breaking API changes prior to shipping 1.0, after which the breaking API changes will stop.

The other thing I'd like to do before v6 is factor apart HTTP::Client (which actually drives making requests) from HTTP::Connection (which manages I/O for a particular connection to an HTTP server)

This mirrors the separation of Reel::Server::* and Reel::Connection in Reel and can pave the way to HTTP pipelining.

@schmurfy
Copy link
Author

ok I understand better now, thanks for the pointers :)
it would be nice to allow direct usage of the Client class in case you want to reuse the connection and not open a new one each time too.

@tarcieri
Copy link
Member

Yeah, long-term goal would be a pool of keepalive connections ala
Net::HTTP::Persistent

On Saturday, January 25, 2014, Julien Ammous notifications@github.com
wrote:

ok I understand better now, thanks for the pointers :)
it would be nice to allow direct usage of the Client class in case you
want to reuse the connection and not open a new one each time too.


Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-33286105
.

Tony Arcieri

@sferik
Copy link
Contributor

sferik commented Mar 4, 2014

@tarcieri Do you want to finish #72 before v0.6 is released? If so, please add it to the v0.6 milestone, otherwise, please add it to the v1.0 milestone. If we decide we need a v0.7 before v1.0, we can create a milestone for that as well. It all depends on how much we want to change and test the API before v1.0 is released.

@tarcieri
Copy link
Member

tarcieri commented Mar 4, 2014

@sferik I wouldn't even call it a blocker for 1.0. It shouldn't cause breaking API changes. If it does we can release 2.0.

I'd rather get a 1.0 shipped.

@ghost
Copy link

ghost commented Mar 5, 2014

i can probably use master too through a Gemfile but it would be nice to have v0.6.0 as a gem.

@tarcieri
Copy link
Member

I pushed 0.6.0.pre to RubyGems. Give 'er a try

@tarcieri
Copy link
Member

tarcieri commented Apr 1, 2014

Barring any objections, I'd like to release 0.6.0 tomorrow

@ghost
Copy link

ghost commented Apr 1, 2014

i've been using master for a few days on a private project, works good for me but to be honest how i'm using it so far is so simple it'd be very strange if it didn't work :P

@tarcieri
Copy link
Member

tarcieri commented Apr 1, 2014

Guess I'll do this tomorrow to avoid an April Fool's Day release 😉

@sferik
Copy link
Contributor

sferik commented Apr 1, 2014

Who cares? Just do it today!

@tarcieri
Copy link
Member

tarcieri commented Apr 1, 2014

LOLOL k

@tarcieri
Copy link
Member

tarcieri commented Apr 1, 2014

Well, I was going to do a release, but Github was down. Tomorrow!

@tarcieri
Copy link
Member

tarcieri commented Apr 2, 2014

After talking with @ixti some more I'm postponing the release temporarily so he can fix a few problems with parameter handling

@tarcieri
Copy link
Member

tarcieri commented Apr 3, 2014

With #120 merged I think we're good to ship

@tarcieri
Copy link
Member

tarcieri commented Apr 4, 2014

Shipped! :shipit: :shipit: :shipit:

https://groups.google.com/forum/#!topic/ruby-http-gem/UPe9kdQLutg

Now let's scramble for a 0.6.1 release 😉

@ghost
Copy link

ghost commented Apr 5, 2014

fwiw i've been using http to make requests to the github API, and works great =D i'm a few commits behind and don't have @ixti's fixes from #120, but no complaints so far. has been very nice to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants