Apply basic authentication from URI #477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URIs can have basic authentication defined in them, for example https://janko:secret@example.com Currently username and password in URIs are ignored. This change modifies HTTP::Client to automatically detect these options and applies basic authentication.
|
Is this RFC-compliant? I didn't know that setting a username and password in the URI should be interpreted as basic auth. |
tycooon
reviewed
May 28, 2018
| uri.password = "secret" | ||
|
|
||
| headers = JSON.parse(HTTP.get("#{uri}/headers").to_s) | ||
| expect(headers["Authorization"]).to match(%r{^Basic [A-Za-z0-9+/]+=*$}) |
There was a problem hiding this comment.
That's actually a constant value, maybe better hardcode it?
Hmm, that's a good question. According to the HTTP Authentication MDN page, doing this is deprecated.
Feel free to close the PR and the issue then 😄 |
|
@HoneyryderChuck interesting question... perhaps we should discuss on #476 (Edit: LOL, @janko-m beat me to exactly what I wanted to say) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URIs can have basic authentication defined in them, for example:
Currently username and password in URIs are ignored. This change modifies HTTP::Client to automatically detect these options and applies basic authentication.
Closes #476