Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client hints] AD review comments #1160

Merged
merged 3 commits into from
Apr 24, 2020
Merged

[client hints] AD review comments #1160

merged 3 commits into from
Apr 24, 2020

Conversation

yoavweiss
Copy link
Contributor

A set of changes following comments as part of the AD review process.

@yoavweiss yoavweiss requested a review from mnot April 23, 2020 16:22
@yoavweiss
Copy link
Contributor Author

@mnot - could you take a look?

mnot
mnot reviewed Apr 24, 2020
View reviewed changes
Copy link
Member

@mnot mnot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoavweiss yoavweiss merged commit 0a3cf38 into httpwg:master Apr 24, 2020
@yoavweiss yoavweiss deleted the ad_review branch April 24, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnot mnot mnot left review comments

@igrigorik igrigorik Awaiting requested review from igrigorik

Assignees
No one assigned
Labels
client-hints
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoavweiss @mnot