Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 6265bis: Update ABNF to define field values #1469

Merged
merged 2 commits into from
May 4, 2021

Conversation

chlily1
Copy link
Contributor

@chlily1 chlily1 commented Apr 21, 2021

This adjusts the ABNF for Set-Cookie and Cookie to define field values, not the whole field line, addressing #1302.

This adjusts the ABNF for Set-Cookie and Cookie to define field values, not the whole field line, addressing #1302.
@chlily1
Copy link
Contributor Author

chlily1 commented Apr 21, 2021

@reschke @englehardt PTAL.

I decided to just refer to set-cookie-string and cookie-string (even though the extra layer of indirection is a bit redundant) because there are still references to those throughout the text and it seemed simpler to keep those.

Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, but I would prefer to get rid of essentially unused ABNF productions.

I also note that the paragraph above ("Syntax") needs work; it should only talk about the syntax of the field value, and not discuss ": etc.

@chlily1
Copy link
Contributor Author

chlily1 commented Apr 21, 2021

I also note that the paragraph above ("Syntax") needs work; it should only talk about the syntax of the field value, and not discuss ": etc.

Thanks for pointing that out! I've updated that as well.

@chlily1 chlily1 merged commit 3155c47 into main May 4, 2021
@chlily1 chlily1 deleted the chlily1-abnf-field-values branch May 4, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants