Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #2384. Non-deterministic content coding beyond encryption. #2422

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Fix: #2384. Non-deterministic content coding beyond encryption. #2422

merged 2 commits into from
Mar 3, 2023

Conversation

ioggstream
Copy link
Contributor

This PR

  • some content-coding are "not deterministic" ;)
  • not only encryption-related ones.

Fix #2384

LPardue
LPardue requested changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@LPardue LPardue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, the core text makes it clearer IMO. I've just proposed a few editorial changes

draft-ietf-httpbis-digest-headers.md Outdated Show resolved Hide resolved
draft-ietf-httpbis-digest-headers.md Outdated Show resolved Hide resolved
@ioggstream @LPardue
Apply suggestions from code review
22815ce 
Co-authored-by: Lucas Pardue <lucaspardue.24.7@gmail.com>
@ioggstream
Copy link
Contributor Author

@LPardue great! I applied them :) Feel free to merge!

@LPardue LPardue merged commit eb83f84 into main Mar 3, 2023
@LPardue LPardue deleted the ioggstream-2384 branch March 3, 2023 01:35
@LPardue
Copy link
Contributor

LPardue commented Mar 3, 2023

merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPardue LPardue Awaiting requested review from LPardue LPardue is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6.5 Usage with Encryption - it isn’t clear what layer of encryption is assumed (representation, content)
2 participants
@ioggstream @LPardue