Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be explicit about number return types #2467

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Be explicit about number return types #2467

merged 1 commit into from
Mar 8, 2023

Conversation

mnot
Copy link
Member

@mnot mnot commented Mar 8, 2023

Fixes #2354.

@mnot mnot requested a review from bsdphk as a code owner March 8, 2023 04:08
@mnot mnot mentioned this pull request Mar 8, 2023
Closed
@mnot mnot requested a review from martinthomson March 8, 2023 04:09
@mnot mnot merged commit b42fefc into main Mar 8, 2023
@mnot mnot deleted the mnot/2354b branch March 8, 2023 22:40
@bsdphk
Copy link
Contributor

bsdphk commented Mar 14, 2023

OK with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson left review comments

@bsdphk bsdphk Awaiting requested review from bsdphk bsdphk is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return type for Integer/Decimal parsing
3 participants
@mnot @bsdphk @martinthomson