Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please let us know if any changes are needed for the following (comment 36) #1072

Closed
mnot opened this issue Mar 22, 2022 · 1 comment · Fixed by #1100
Closed

Please let us know if any changes are needed for the following (comment 36) #1072

mnot opened this issue Mar 22, 2022 · 1 comment · Fixed by #1100
Labels

Comments

@mnot
Copy link
Member

mnot commented Mar 22, 2022

Please let us know if any changes are needed for the
following:

a) The following terms were used inconsistently in this document.
We chose to use the latter forms. Please let us know any objections.

flow control credit / flow-control credit
(We also changed "flow control signal" to "flow-control signal".)

flow control window (1 instance in Section 5.2.3) /
flow-control window (approx. 45 instances)

HTTP 1.1 (1 instance) / HTTP/1.1 (22 instances)

"Promised Stream ID" field / Promised Stream ID field
(There was only one quoted field name in this document.)

stream identifier field (6 instances) /
Stream Identifier field (10 instances)

Upgrade token / upgrade token (per RFC 7540 and companion
document RFC 9110)

b) The following terms appear to be used inconsistently in this
document. Please let us know which form is preferred.

closed stream (or closed streams) (5 instances) /
"closed" stream (1 instance)

idle stream (5 instances) / "idle" streams (1 instance)

reserved stream (or reserved streams) (4 instances) /
"reserved" streams (1 instance)

@mnot mnot added the auth48 label Mar 22, 2022
@martinthomson
Copy link
Collaborator

For stream states, I think we have a convention. We talk about a stream in the "idle" state or we talk about an idle stream. I think that's OK.

@Lukasa, you will have to double check the pull request I have for this as there were a few inconsistencies about our use of "reserved". These carry over from the previous version and were not very precise.

martinthomson added a commit to martinthomson/http2v2 that referenced this issue Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants