Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaea intel 2022 update, reg. tests updates for Jet,Hera,Orion,Cheyenne,Gaea #11

Merged
merged 18 commits into from
Jun 29, 2023

Conversation

natalie-perlin
Copy link

@natalie-perlin natalie-perlin commented Jun 14, 2023

Description

  • Allow building the GSI enkf.x and gsi.x binaries on Gaea using updated software stack with intel-classic-2022.0.2 compiler and cray-mpich/7.7.20 on upgraded Gaea partitions C3 and C4.

  • Updated GSI/fix file locations on Jet, Orion, Hera to the most recent date

  • Added GSI fix locations to Cheyenne and Gaea, pointing to data staged in EPIC locations.

  • Added submission script for gaea and regression tests configuration

  • ncdiag update to 1.1.1

  • Staged regression tests data on Cheyenne, Gaea

  • Updated regression tests configuration for Cheyenne, Gaea, Jet, Orion

Files changes:
Gaea build:
./ush/module-setup.sh
./modulefiles/gsi_gaea.lua
(deleted) modulefiles/gsi_gaea
./modulefiles/gsi_common.lua
./ush/sub_gaea (new)
./ush/sub_cheyenne (new)
./regression_var.sh
./regression_param.sh

Fix files location update:
gsi_jet.lua
gsi_orion.lua
gsi_cheyenne.intel.lua
gsi_hera.intel.lua

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Builds on Gaea successful for C3/C4.
Regression tests successfully complete for Hera, Orion, Gaea, Cheyenne, Jet (for the software stacks build with intel compilers)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Contribution

@DavidHuber-NOAA

@DavidHuber-NOAA
Copy link

I've updated #10 to include these changes, so I think this can be closed.

Copy link

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some debugging code needs removing.

regression/regression_driver.sh Outdated Show resolved Hide resolved
regression/regression_param.sh Show resolved Hide resolved
ush/build.sh Outdated Show resolved Hide resolved
ush/build.sh Outdated Show resolved Hide resolved
ush/sub_gaea Outdated Show resolved Hide resolved
regression/regression_var.sh Outdated Show resolved Hide resolved
regression/regression_var.sh Outdated Show resolved Hide resolved
regression/regression_var.sh Outdated Show resolved Hide resolved
regression/regression_var.sh Outdated Show resolved Hide resolved
ush/build.sh Outdated Show resolved Hide resolved
ush/sub_jet Outdated Show resolved Hide resolved
ush/build.sh Outdated Show resolved Hide resolved
regression/regression_var.sh Outdated Show resolved Hide resolved
regression/regression_var.sh Outdated Show resolved Hide resolved
ush/sub_gaea Outdated Show resolved Hide resolved
regression/regression_var.sh Outdated Show resolved Hide resolved
@DavidHuber-NOAA
Copy link

This looks good to me. @hu5970 Can you go ahead and merge this?

@natalie-perlin natalie-perlin changed the title Gaea intel 2022 update, fix files location update on Jet,Hera,Orion,G… Gaea intel 2022, reg. tests scripts updates for Jet,Hera,Orion,Cheyenne,Gaea Jun 28, 2023
@natalie-perlin natalie-perlin changed the title Gaea intel 2022, reg. tests scripts updates for Jet,Hera,Orion,Cheyenne,Gaea Gaea intel 2022 update, reg. tests updates for Jet,Hera,Orion,Cheyenne,Gaea Jun 28, 2023
@hu5970 hu5970 merged commit c077a1c into hu5970:intel2022 Jun 29, 2023
@natalie-perlin natalie-perlin deleted the intel2022_gaea branch June 29, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants