Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ember-CLI 2.11.1 #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Gmfholley
Copy link

I upgraded the project to ember-cli 2.11.1 (also upgrades many of the other modules). I was unable to use this addon in our project without this update.

Ember tests pass and Ember server is running without warnings.
I also tested it with my own project and it seems to work well.

  • baseURL was deprecated but converting to rootURL did not fix the tests. Adding <base href="/> to the test's index.html file allowed the tests to run properly.
    https://www.emberjs.com/blog/2016/04/28/baseURL.html
  • moved the ember-cli-test-loader from bower to an npm module based on deprecation warnings
  • updated the setup & teardown of tests to the new way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant