Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to create GitterClient with coffee-script > 1.8 #29

Closed
gburgett opened this issue May 23, 2017 · 1 comment
Closed

Fails to create GitterClient with coffee-script > 1.8 #29

gburgett opened this issue May 23, 2017 · 1 comment

Comments

@gburgett
Copy link

Reference Error on startup with CoffeeScript >=1.9
Fails even with CoffeeScript v1.12.6 (latest)

With CoffeeScript 1.9.0:

ReferenceError: no id given to create an object: null, [object Object<token,id>]
  at GitterClient.GitterObject [as constructor] (./node_modules/hubot-gitter2/src/GitterObject.coffee:107:15)
  at new GitterClient (./node_modules/hubot-gitter2/src/GitterClient.coffee:34:5)
  at Function.GitterObject.factory (./node_modules/hubot-gitter2/src/GitterObject.coffee:67:49)
  at Function.GitterClient.factory (./node_modules/hubot-gitter2/src/GitterClient.coffee:24:26)
  at HubotGitter2Adapter.gitterClient (./node_modules/hubot-gitter2/src/HubotGitter2Adapter.coffee:120:31)
  at HubotGitter2Adapter.run (./node_modules/hubot-gitter2/src/HubotGitter2Adapter.coffee:82:11)
  at Robot.run (./node_modules/hubot/src/robot.coffee:587:14)

With CoffeeScript 1.8.0:

[hubot-gitter2.debug][object GitterClient<f21a0ae5e899ffc2669cc1215efcf1b5aa19227a>] overriding {client#get}
[hubot-gitter2.debug][object GitterClient<f21a0ae5e899ffc2669cc1215efcf1b5aa19227a>] overriding {client#post}
[hubot-gitter2.debug][object GitterClient<f21a0ae5e899ffc2669cc1215efcf1b5aa19227a>] overriding {client#put}
[hubot-gitter2.debug][object GitterClient<f21a0ae5e899ffc2669cc1215efcf1b5aa19227a>] overriding {client#patch}
[hubot-gitter2.debug][object GitterClient<f21a0ae5e899ffc2669cc1215efcf1b5aa19227a>] overriding {client#delete}
[hubot-gitter2.debug][object GitterClient<f21a0ae5e899ffc2669cc1215efcf1b5aa19227a>] overriding {client#request}
[hubot-gitter2.debug][object GitterClient<f21a0ae5e899ffc2669cc1215efcf1b5aa19227a>] overriding {client#stream}
[hubot-gitter2.debug][object GitterClient<f21a0ae5e899ffc2669cc1215efcf1b5aa19227a>] creating promise `users.current`
[hubot-gitter2.debug][object GitterClient<f21a0ae5e899ffc2669cc1215efcf1b5aa19227a>] {client#get} [/user]
[hubot-gitter2.debug][object GitterClient<f21a0ae5e899ffc2669cc1215efcf1b5aa19227a>] {client#request} [GET, /user, ]
[hubot-gitter2.debug][object GitterClient<f21a0ae5e899ffc2669cc1215efcf1b5aa19227a>] created
@gburgett
Copy link
Author

Never mind, it's fixed in #10, it's just that you haven't repackaged and pushed this change to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants