Fix data.id check in GitterObject #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New coffee parser converts constructor: (@_client, @_data) -> to function GitterObject(_client, _data1)
huafu
added a commit
that referenced
this pull request
Feb 13, 2016
Fix data.id check in GitterObject
gburgett
added a commit
to CruAlbania/crubot
that referenced
this pull request
May 23, 2017
…nge in coffee-script@1.9 see huafu/hubot-gitter2#10 for more info
gburgett
added a commit
to CruAlbania/crubot
that referenced
this pull request
May 27, 2017
…nge in coffee-script@1.9 see huafu/hubot-gitter2#10 for more info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New coffee parser (I tried 1.10.0) converts
constructor: (@_client, @_data) ->tofunction GitterObject(_client, _data1)and the_datacheck always fails because_datais renamed to_data1.Thank you.