Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support ClickHouse Grammar #92

Merged
merged 5 commits into from
Dec 15, 2022
Merged

feat: Support ClickHouse Grammar #92

merged 5 commits into from
Dec 15, 2022

Conversation

hanyuancheung
Copy link
Contributor

  • Support ClickHouse basic grammar.

@hanyuancheung
Copy link
Contributor Author

hi @huandu
I've found that sqlbuilder still not support clickhouse grammar, so I contribute this part to use this tool to generate sql statement. Could you please to review it, thanks.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 96.011% when pulling b73711d on hanyuancheung:feature/support_clickhouse_grammar into f299327 on huandu:master.

huandu
huandu requested changes Dec 13, 2022
View reviewed changes
interpolate.go Outdated Show resolved Hide resolved
flavor.go Outdated Show resolved Hide resolved
@huandu
Copy link
Owner

huandu commented Dec 13, 2022

Thanks for your contribution! Please review my feedback and make changes. Feel free to discuss with me if you have any question.

@hanyuancheung
Copy link
Contributor Author

Thanks for your contribution! Please review my feedback and make changes. Feel free to discuss with me if you have any question.

Thanks for ur reply. I've fixed these comments.

huandu
huandu requested changes Dec 14, 2022
View reviewed changes
Copy link
Owner

@huandu huandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some blocking issues. Please fix them. Thanks.

interpolate.go Outdated Show resolved Hide resolved
interpolate.go Outdated Show resolved Hide resolved
interpolate_test.go Outdated Show resolved Hide resolved
@hanyuancheung
Copy link
Contributor Author

There are still some blocking issues. Please fix them. Thanks.

Sure, I've fixed them and tested in my local clickhouse. It works well. Thanks for the advice.

huandu
huandu approved these changes Dec 15, 2022
View reviewed changes
Copy link
Owner

@huandu huandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@huandu huandu merged commit 60fd0c4 into huandu:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huandu huandu huandu approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hanyuancheung @coveralls @huandu