Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect project version downgrade #1611

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

alecharp
Copy link
Contributor

@alecharp alecharp commented Feb 1, 2023

This was introduced in 30ff8e6 and I believe it is a mistake

Description

Project version was downgraded to 1.312-SNAPSHOT when the project already has releases for 1.312 and 1.313.

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

This was introduced in 30ff8e6 and I believe it is a mistake
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 79.22% // Head: 79.22% // No change to project coverage 👍

Coverage data is based on head (9a084e8) compared to base (54d60fb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1611   +/-   ##
=========================================
  Coverage     79.22%   79.22%           
  Complexity     2141     2141           
=========================================
  Files           206      206           
  Lines          6576     6576           
  Branches        364      364           
=========================================
  Hits           5210     5210           
  Misses         1154     1154           
  Partials        212      212           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alecharp
Copy link
Contributor Author

alecharp commented Feb 3, 2023

@bitwiseman is there anything I can help with to get this and #1612 merged and have a release?

@bitwiseman bitwiseman merged commit 612f5ec into hub4j:main Feb 3, 2023
@alecharp alecharp deleted the fix/incorrect-project-version branch February 28, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants