Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter check runs to retrieve from commit #1612

Merged
merged 7 commits into from
Feb 25, 2023

Conversation

alecharp
Copy link
Contributor

@alecharp alecharp commented Feb 1, 2023

Description

From https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#list-check-runs-for-a-git-reference, there are parameters we can provide to filter the Check which are retrieved.

Creating a method for each parameter didn't seem like a good idea, so I just inject potential parameters on the request.

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 79.22% // Head: 79.30% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (4df01a0) compared to base (612f5ec).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1612      +/-   ##
============================================
+ Coverage     79.22%   79.30%   +0.07%     
- Complexity     2141     2142       +1     
============================================
  Files           206      206              
  Lines          6576     6582       +6     
  Branches        364      364              
============================================
+ Hits           5210     5220      +10     
+ Misses         1154     1150       -4     
  Partials        212      212              
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GHRepository.java 69.39% <100.00%> (+0.28%) ⬆️
...rc/main/java/org/kohsuke/github/GitHubRequest.java 93.58% <0.00%> (+2.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

alecharp added a commit to alecharp/plugin-health-scoring that referenced this pull request Feb 2, 2023
@alecharp alecharp changed the title Feature/filter check runs on commit Filter check runs to retrieve from commit Feb 2, 2023
@alecharp alecharp mentioned this pull request Feb 3, 2023
10 tasks
@alecharp
Copy link
Contributor Author

@bitwiseman do you think this is good enough to be merged and have a release of the library?

@bitwiseman bitwiseman merged commit 467e726 into hub4j:main Feb 25, 2023
@bitwiseman
Copy link
Member

@alecharp Sorry for the delay. I'll get a release out tonight.

@alecharp
Copy link
Contributor Author

No problem @bitwiseman. thank you very much for this PI release ;)

@alecharp alecharp deleted the feature/filter-check-runs-on-commit branch February 28, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants